University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Add pre-execution checks with CommandHandlerExecutor to CommandHandler #242

Merged
lars.winzer merged 12 commits from feat/57-pre-execution-checks-for-commandhandler into main 2026-04-08 18:58:21 +02:00
Conversation 5 Commits 12 Files Changed 18
+257 -22
lars.winzer commented 2026-04-08 18:29:23 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Refactored relation with SessionManager and NetworkManager by moving CommandRouter relation from SessionManager to NetworkManager.

Added HandlerCheck functional interface to allow for pre-execution checks as both named classes and stateless lambda.

Added CommandHandlerExecutor to perform defined HandlerChecks and invoke execution of CommandHandler if all checks passed.

Modified CommandRouter to delegate execution of HandlerChecks and CommandHandler .

Added UserLoggedInCheck to perform check if Session is associated with User, i.e. logged in.

Modified guide on adding a command aswell as the deep-dive with the new components.

Closes #57

Refactored relation with `SessionManager` and `NetworkManager` by moving `CommandRouter` relation from `SessionManager` to `NetworkManager`. Added `HandlerCheck` functional interface to allow for pre-execution checks as both named classes and stateless lambda. Added `CommandHandlerExecutor` to perform defined `HandlerCheck`s and invoke execution of `CommandHandler` if all checks passed. Modified CommandRouter to delegate execution of `HandlerChecks` and `CommandHandler` . Added `UserLoggedInCheck` to perform check if `Session` is associated with `User`, i.e. logged in. Modified guide on adding a command aswell as the deep-dive with the new components. Closes #57
lars.winzer commented 2026-04-08 18:30:36 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Somehow the changed filename was not pushed.

Somehow the changed filename was not pushed.
lars.winzer commented 2026-04-08 18:31:46 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 1 commit

  • e23a9817 - Refactor: Rename file to match class name

Compare with previous version

added 1 commit <ul><li>e23a9817 - Refactor: Rename file to match class name</li></ul> [Compare with previous version](/cs108-fs26/Gruppe-13/-/merge_requests/86/diffs?diff_id=14367&start_sha=1b3ba0000a1048c1e7ce844357b68e60d5f1ade9)
lars.winzer (Migrated from git.scicore.unibas.ch) scheduled this pull request to auto merge when all checks succeed 2026-04-08 18:33:17 +02:00
lars.winzer commented 2026-04-08 18:54:16 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

aborted the automatic merge because the source branch was updated. Learn more.

aborted the automatic merge because the source branch was updated. [Learn more](https://git.scicore.unibas.ch/help/ci/pipelines/merge_trains.md#merge-request-dropped-from-the-merge-train).
lars.winzer commented 2026-04-08 18:54:16 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 1 commit

  • 3de20e3d - Docs: Remove unnecessary generic type parameter in JavaDoc from execute method...

Compare with previous version

added 1 commit <ul><li>3de20e3d - Docs: Remove unnecessary generic type parameter in JavaDoc from execute method...</li></ul> [Compare with previous version](/cs108-fs26/Gruppe-13/-/merge_requests/86/diffs?diff_id=14369&start_sha=e23a9817e287c0e7a6b98877707c15a2bf3ef592)
lars.winzer commented 2026-04-08 18:58:21 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 795830cf02

mentioned in commit 795830cf02fb7c902b20839e55719235e53fe9ba
lars.winzer (Migrated from git.scicore.unibas.ch) merged commit 795830cf02 into main 2026-04-08 18:58:21 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#242
Delete Branch "feat/57-pre-execution-checks-for-commandhandler"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?