University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Pre-execution checks for CommandHandler #57

New Issue
Closed
opened 2026-04-07 17:44:21 +02:00 by lars.winzer · 5 comments
lars.winzer commented 2026-04-07 17:44:21 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Feature Request

Summary

A system providing the ability for checks before the execution of the execute method, is needed.

Required workarround

Each check (i.e. if the session is associated with a user) has to be evaluated in the execute method. This includes responding to the request early, if a requirement is not met, and aborting further execution.

It quickly leads to a degradation of code quality as code is duplicated.

Description

The system builds on the FunctionalInterface annotation allowing for both named classes and stateless lambda.

The checks are evaluated by the CommandRouter. If all checks pass, the execute method is invoked. If not, the Response returned by the check is dispatched to the client.

Checklist

  • I have described the function in detail
  • I searched docs for alternative implementations matching my needs
  • I added relevant labels
## Feature Request <!--The reccommended type is: Task--> ### Summary A system providing the ability for checks before the execution of the execute method, is needed. ### Required workarround Each check (i.e. if the session is associated with a user) has to be evaluated in the execute method. This includes responding to the request early, if a requirement is not met, and aborting further execution. It quickly leads to a degradation of code quality as code is duplicated. ### Description The system builds on the FunctionalInterface annotation allowing for both named classes and stateless lambda. The checks are evaluated by the `CommandRouter`. If all checks pass, the execute method is invoked. If not, the `Response` returned by the check is dispatched to the client. ### Checklist - [x] I have described the function in detail - [x] I searched docs for alternative implementations matching my needs - [x] I added relevant labels
lars.winzer commented 2026-04-08 16:30:08 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-04-08 16:30:47 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch feat/57-pre-execution-checks-for-commandhandler to address this issue

created branch [`feat/57-pre-execution-checks-for-commandhandler`](/cs108-fs26/Gruppe-13/-/compare/main...feat%2F57-pre-execution-checks-for-commandhandler) to address this issue
lars.winzer commented 2026-04-08 18:21:21 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 1h 50m of time spent at 2026-04-08 12:00:00 +0200

added 1h 50m of time spent at 2026-04-08 12:00:00 +0200
lars.winzer commented 2026-04-08 18:29:25 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !86

mentioned in merge request !86
lars.winzer commented 2026-04-08 18:58:21 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 795830cf02

mentioned in commit 795830cf02fb7c902b20839e55719235e53fe9ba
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-08 18:58:22 +02:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label commands enhancement server
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#57
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?