University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Disallow failure of checkstyle linter in merge requests #210

Merged
lars.winzer merged 3 commits from feat/22-disallow-failure-of-checkstyle-mr-job into main 2026-03-30 14:23:48 +02:00
Conversation 5 Commits 3 Files Changed 1
+3 -2
lars.winzer commented 2026-03-30 14:17:19 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Disallowed the failure of the checkstyle-mr job to block merge action on merge request.

Modified checkstyle-report job condition to run always, even if checkstyle-mr job fails (hopefully).

Disallowed the failure of the `checkstyle-mr` job to block merge action on merge request. Modified `checkstyle-report` job condition to run always, even if checkstyle-mr job fails (hopefully).
lars.winzer commented 2026-03-30 14:19:30 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Confirmed that the merge request is indeed blocked and the checkstyle-report job is allowed to run.

Confirmed that the merge request is indeed blocked and the `checkstyle-report` job is allowed to run.
lars.winzer commented 2026-03-30 14:20:06 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 1 commit

Compare with previous version

added 1 commit <ul><li>9d4afdc3 - Remove: Violator dummy file</li></ul> [Compare with previous version](/cs108-fs26/Gruppe-13/-/merge_requests/54/diffs?diff_id=14222&start_sha=f9b866fc403f3f8d67a0da585778fe2eee3945e7)
lars.winzer commented 2026-03-30 14:23:41 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Closes #22

Closes #22
lars.winzer commented 2026-03-30 14:23:48 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 978f54a57b

mentioned in commit 978f54a57b78d70af2ec7ef858aecffad957c098
lars.winzer (Migrated from git.scicore.unibas.ch) merged commit 978f54a57b into main 2026-03-30 14:23:48 +02:00
lars.winzer commented 2026-03-30 14:24:04 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in task #22

mentioned in task #22
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#210
Delete Branch "feat/22-disallow-failure-of-checkstyle-mr-job"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?