University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Disallow failure of checkstyle-mr job to block merge request #22

New Issue
Closed
opened 2026-03-30 13:43:04 +02:00 by lars.winzer · 6 comments
lars.winzer commented 2026-03-30 13:43:04 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Feature Request

Summary

Merge requests should be blocked if checkstyle-mr job fails, allowing the contributor to adress these issues.

Required workarround

After the MR has been merged, its required to create another branch (chore/... ) to address these issues.

This workaround unnecessarily complicates the fix and makes it harder to track the history.

Description

Modify job to disallow failure.

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation docs for relevant information
  • I added relevant labels
## Feature Request <!--The reccommended type is: Task--> ### Summary Merge requests should be blocked if `checkstyle-mr` job fails, allowing the contributor to adress these issues. ### Required workarround After the MR has been merged, its required to create another branch (`chore/...` ) to address these issues. This workaround unnecessarily complicates the fix and makes it harder to track the history. ### Description Modify job to disallow failure. ### Checklist - [x] ~~I reproduced the problem using the steps above~~ - [x] ~~I searched documentation docs for relevant information~~ - [x] I added relevant labels
lars.winzer commented 2026-03-30 13:45:32 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-03-30 13:46:04 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch feat/22-disallow-failure-of-checkstyle-mr-job to address this issue

created branch [`feat/22-disallow-failure-of-checkstyle-mr-job`](/cs108-fs26/Gruppe-13/-/compare/main...feat%2F22-disallow-failure-of-checkstyle-mr-job) to address this issue
lars.winzer commented 2026-03-30 13:59:21 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked this task as related to #24

marked this task as related to #24
lars.winzer commented 2026-03-30 14:23:41 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !54

mentioned in merge request !54
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-03-30 14:24:03 +02:00
lars.winzer commented 2026-03-30 14:24:04 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Closed by https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/54

Closed by https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/54
lars.winzer commented 2026-03-30 14:26:33 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 30m of time spent at 2026-03-30 12:00:00 +0200

added 30m of time spent at 2026-03-30 12:00:00 +0200
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label ci enhancement linting
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#22
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?