University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Short logger names to reduce visual clutter in log output #322

Merged
lars.winzer merged 3 commits from feat/60-shorten-logger-name into main 2026-05-12 19:06:57 +02:00
Conversation 12 Commits 3 Files Changed 22
+32 -23
lars.winzer commented 2026-05-12 13:06:17 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Refactored each instantiation of a new logger (LogManager.getLogger) to get the simple name of the class, instead of the full classpath.

Note

As I partially modified other peoples code, they (@jona.walpert, @j.kropff and @m.ginkel) need to approve this MR before it can be merged.

Closes #60

Refactored each instantiation of a new logger (`LogManager.getLogger`) to get the simple name of the class, instead of the full classpath. > [!note] > > As I partially modified other peoples code, they (@jona.walpert, @j.kropff and @m.ginkel) need to approve this MR before it can be merged. Closes #60
lars.winzer commented 2026-05-12 13:06:17 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

requested review from @jona.walpert

requested review from @jona.walpert
lars.winzer commented 2026-05-12 13:06:27 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

requested review from @j.kropff and removed review request for @jona.walpert

requested review from @j.kropff and removed review request for @jona.walpert
lars.winzer commented 2026-05-12 13:06:37 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

requested review from @jona.walpert and removed review request for @j.kropff

requested review from @jona.walpert and removed review request for @j.kropff
lars.winzer commented 2026-05-12 13:07:11 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

requested review from @jona.walpert

requested review from @jona.walpert
lars.winzer commented 2026-05-12 13:08:21 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Jeez, why cant I request the review from multiple team members?

Jeez, why cant I request the review from multiple team members?
m.ginkel commented 2026-05-12 13:17:35 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

approved this merge request

approved this merge request
jona.walpert commented 2026-05-12 15:19:07 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

approved this merge request

approved this merge request
j.kropff commented 2026-05-12 19:06:09 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

approved this merge request

approved this merge request
lars.winzer (Migrated from git.scicore.unibas.ch) merged commit baa1d51a1f into main 2026-05-12 19:06:57 +02:00
lars.winzer commented 2026-05-12 19:06:58 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit baa1d51a1f

mentioned in commit baa1d51a1fa78002bfbfa639087fda044bec859f
m.ginkel (Migrated from git.scicore.unibas.ch) approved these changes 2026-05-29 17:37:52 +02:00
jona.walpert (Migrated from git.scicore.unibas.ch) approved these changes 2026-05-29 17:37:52 +02:00
j.kropff (Migrated from git.scicore.unibas.ch) approved these changes 2026-05-29 17:37:52 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
j.kropff
m.ginkel
jona.walpert
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label
Milestone
No items
No Milestone Milestone 6
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#322
Delete Branch "feat/60-shorten-logger-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?