University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Feat: New Game UI Features and bug fixed #308

Merged
j.kropff merged 19 commits from feat/game-ui-optimation into main 2026-04-26 17:52:41 +02:00
Conversation 2 Commits 19 Files Changed 16
+1863 -119
j.kropff commented 2026-04-26 17:50:30 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

New Game UI Features:

  • Call, Raise, Fold, Bet and Winner action are displayed in the Lobby Chat.
  • More security features in the Game UI
  • The Game UI is now even more Texas Hold'em-friendly
  • You can see whose turn it is graphically
  • Casono Browser features
    • Manual available in the Casono Browser
    • Dowlaod Blocking
    • Automatic website autocompletion

Refs #125

New Game UI Features: - Call, Raise, Fold, Bet and Winner action are displayed in the Lobby Chat. - More security features in the Game UI - The Game UI is now even more Texas Hold'em-friendly - You can see whose turn it is graphically - Casono Browser features * Manual available in the Casono Browser * Dowlaod Blocking * Automatic website autocompletion Refs #125
j.kropff commented 2026-04-26 17:52:41 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 2ad99d8732

mentioned in commit 2ad99d87326ff16f0ecf14536224622cc807a17c
j.kropff (Migrated from git.scicore.unibas.ch) merged commit 2ad99d8732 into main 2026-04-26 17:52:41 +02:00
lars.winzer commented 2026-04-26 18:43:37 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

The commit sizes are generally fine. fb68ecc777, 09f8ddf123 and c11201479b are at pushing it but still within acceptable limits.

However, with nearly 2,000 changes, this merge request is already quite large.

If an existing feature has been broken during these optimizations, you can only revert the entire merge request.

Keeping individual changes is difficult. Just keep that in mind for the future.

The commit sizes are generally fine. fb68ecc7778b2e28aaa0b7cde2421fa88a1f3faa, 09f8ddf123ce9a082b4b8362e343755bc0a9fcbf and c11201479be27420349524eba5e019af5f635cca are at pushing it but still within acceptable limits. However, with nearly 2,000 changes, this merge request is already quite large. If an existing feature has been broken during these optimizations, you can only revert the entire merge request. Keeping individual changes is difficult. Just keep that in mind for the future.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#308
Delete Branch "feat/game-ui-optimation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?