University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Feat/client chat #251

Closed
m.ginkel wants to merge 0 commits from feat/client-chat into main
pull from: feat/client-chat
merge into: University-of-Basel-Studentprojects:main
Conversation 5 Commits - Files Changed -
m.ginkel commented 2026-04-11 11:19:52 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

This merge should add the Client-to-Client Chat Feature, including the Chat UI and the Server Command

Closes #71

This merge should add the Client-to-Client Chat Feature, including the Chat UI and the Server Command Closes #71
m.ginkel commented 2026-04-11 11:19:52 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @m.ginkel

assigned to @m.ginkel
m.ginkel commented 2026-04-11 11:22:04 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

approved this merge request

approved this merge request
lars.winzer commented 2026-04-11 11:28:04 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

The title of the merge request still does not reflect the fact that it contains changes to both client and server components.

The description is rudimentary and inadequate; it does not describe which changes are being introduced.

In addition, changes are being made to components of the server-side infrastructure:

- The visibility modifiers of the SuccessResponse have been changed, and the class is no longer abstract.

- There are changes to the components for the “CHECK_USERNAME” command that have nothing to do with this merge request.

The title of the merge request still does not reflect the fact that it contains changes to both client and server components. The description is rudimentary and inadequate; it does not describe which changes are being introduced. In addition, changes are being made to components of the server-side infrastructure: \- The visibility modifiers of the SuccessResponse have been changed, and the class is no longer abstract. \- There are changes to the components for the “CHECK_USERNAME” command that have nothing to do with this merge request.
m.ginkel commented 2026-04-11 11:56:17 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 1 commit

  • 590a9aa6 - Style: Manually revert changes made to UsernameAvailability enum

Compare with previous version

added 1 commit <ul><li>590a9aa6 - Style: Manually revert changes made to UsernameAvailability enum</li></ul> [Compare with previous version](/cs108-fs26/Gruppe-13/-/merge_requests/95/diffs?diff_id=14451&start_sha=66d3826509b57ac79fcbed5251f46a6e69ac7035)
m.ginkel (Migrated from git.scicore.unibas.ch) closed this pull request 2026-04-11 12:37:16 +02:00
m.ginkel (Migrated from git.scicore.unibas.ch) approved these changes 2026-05-29 17:38:50 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
m.ginkel
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label client messages server task ui
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#251
Delete Branch "feat/client-chat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?