University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Feat/client chat #248

Closed
m.ginkel wants to merge 0 commits from feat/client-chat into main
pull from: feat/client-chat
merge into: University-of-Basel-Studentprojects:main
Conversation 4 Commits - Files Changed -
+276 -303
m.ginkel commented 2026-04-09 21:32:48 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

The Feature of a Client-to-Client Chat implemented with GUI and Server Commands

The Feature of a Client-to-Client Chat implemented with GUI and Server Commands
m.ginkel commented 2026-04-09 21:32:48 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @m.ginkel

assigned to @m.ginkel
m.ginkel commented 2026-04-09 21:34:40 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 13 commits

  • 13df8db3...983d31c9 - 12 commits from branch main
  • 1914aa2c - Merge branch 'main' into 'feat/client-chat'

Compare with previous version

added 13 commits <ul><li>13df8db3...983d31c9 - 12 commits from branch <code>main</code></li><li>1914aa2c - Merge branch &#39;main&#39; into &#39;feat/client-chat&#39;</li></ul> [Compare with previous version](/cs108-fs26/Gruppe-13/-/merge_requests/92/diffs?diff_id=14389&start_sha=13df8db33ee470a1b84855fe86cad927c37bcad3)
lars.winzer commented 2026-04-09 21:49:51 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

This merge request has the ~client label and includes "client" in the title, but introduces changes for the server.

This merge request has the ~client label and includes "client" in the title, but introduces changes for the server.
lars.winzer commented 2026-04-09 22:02:19 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

With over 2,600 changes spread across 48 files, this merge request is also too large.

In addition, the following changes, some of which have nothing directly to do with the subject matter of these changes, are a thorn in my eye:

  • There are changes to the game (card) - unrelated to the client chat
  • Changes to the CHECK_NICK command, particularly an (unnecessary) change to the visibility modifier of the UsernameAvailability enum. As well as further refactoring changes.
  • The disconnect threshold has been increased from 5 seconds to 30 seconds.
  • The entire code within a function has been commented out, but the function itself has not been removed. The entire MessageManager has been marked with a “NOT USED” comment but is still included in the source code.
  • There is an additional document describing the network protocol commands without modifying the existing document.
With over 2,600 changes spread across 48 files, this merge request is also too large. In addition, the following changes, some of which have nothing directly to do with the subject matter of these changes, are a thorn in my eye: * There are changes to the game (card) - unrelated to the client chat * Changes to the CHECK_NICK command, particularly an (unnecessary) change to the visibility modifier of the UsernameAvailability enum. As well as further refactoring changes. * The disconnect threshold has been increased from 5 seconds to 30 seconds. * The entire code within a function has been commented out, but the function itself has not been removed. The entire MessageManager has been marked with a “NOT USED” comment but is still included in the source code. * There is an additional document describing the network protocol commands without modifying the existing document.
m.ginkel (Migrated from git.scicore.unibas.ch) closed this pull request 2026-04-09 22:12:43 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label client messages task ui
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#248
Delete Branch "feat/client-chat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?