University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Fix incorrect order data was written by TcpTransport #215

Merged
lars.winzer merged 1 commits from fix/28-incomplete-transmission-of-response into main 2026-03-31 12:12:58 +02:00
Conversation 2 Commits 1 Files Changed 1
+1 -1
lars.winzer commented 2026-03-31 12:11:55 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Out specification for the data is as follows

  1. Payload size (4 byte)
  2. Request ID generated by the client and not used by the server (4 byte)
  3. Payload itself of size specified in the first 4 byte

I got things mixed up and 1 and 2 were reversed for the write function.

Fixed the incorrect order was written to the DataOutputStream.

Closes #28

Out specification for the data is as follows 1. Payload size (4 byte) 2. Request ID generated by the client and not used by the server (4 byte) 3. Payload itself of size specified in the first 4 byte I got things mixed up and 1 and 2 were reversed for the `write` function. Fixed the incorrect order was written to the DataOutputStream. Closes #28
lars.winzer commented 2026-03-31 12:12:05 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

changed the description

changed the description
lars.winzer (Migrated from git.scicore.unibas.ch) scheduled this pull request to auto merge when all checks succeed 2026-03-31 12:12:54 +02:00
lars.winzer commented 2026-03-31 12:12:58 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 238cf937f4

mentioned in commit 238cf937f4851455ecc4a53f5a9971423de98667
lars.winzer (Migrated from git.scicore.unibas.ch) merged commit 238cf937f4 into main 2026-03-31 12:12:58 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#215
Delete Branch "fix/28-incomplete-transmission-of-response"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?