University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Add RequestContext to simplify creation of Request which requires SessionId and RequestId #201

Merged
lars.winzer merged 7 commits from feat/request-context-record into main 2026-03-24 18:29:28 +01:00
Conversation 1 Commits 7 Files Changed 6
+55 -8
lars.winzer commented 2026-03-24 18:27:54 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Added RequestContext record to contain SessionId and RequestId.

Added RawRequest to serve as an intermediate object between parsing and creation of the PrimitiveRequest.

Refactored ProtocolParser to take a payload string and return RawRequest.

Refactored PrimitiveRequest and Request to contain RequestContext. Added getter methods to Request .

The reason for the refactoring and addition of a new intermediate type was the issue with PrimitiveRequest being immutable after creation.

Options were either to:

  1. Change the PrimitiveRequest to be a class. Subsequently, the RequestContext could be provided via a setter method.
  2. Add a new intermediate type to be created by the ProtocolParser. The SessionReader will then instantiate the PrimitiveRequest before calling the CommandParserDispatcher.

I opted for the second approach, as it was, in my eyes, the cleanest.

Closes #12

Added `RequestContext` record to contain `SessionId` and `RequestId`. Added `RawRequest` to serve as an intermediate object between parsing and creation of the `PrimitiveRequest`. Refactored `ProtocolParser` to take a payload string and return `RawRequest`. Refactored `PrimitiveRequest` and `Request` to contain `RequestContext`. Added getter methods to `Request` . The reason for the refactoring and addition of a new intermediate type was the issue with `PrimitiveRequest` being immutable after creation. Options were either to: 1. Change the `PrimitiveRequest` to be a class. Subsequently, the RequestContext could be provided via a setter method. 2. Add a new intermediate type to be created by the `ProtocolParser`. The `SessionReader` will then instantiate the `PrimitiveRequest` before calling the `CommandParserDispatcher`. I opted for the second approach, as it was, in my eyes, the cleanest. Closes #12
lars.winzer (Migrated from git.scicore.unibas.ch) scheduled this pull request to auto merge when all checks succeed 2026-03-24 18:27:58 +01:00
lars.winzer (Migrated from git.scicore.unibas.ch) merged commit 4234149b58 into main 2026-03-24 18:29:28 +01:00
lars.winzer commented 2026-03-24 18:29:29 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 4234149b58

mentioned in commit 4234149b584e824ca4594bc97e213673e3712514
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#201
Delete Branch "feat/request-context-record"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?