University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Align Checkstyle rules with Spotless #194

Merged
lars.winzer merged 4 commits from issue/2-inconsistency-of-linting-between-checkstyle-and-spotless into main 2026-03-18 18:23:46 +01:00
Conversation 2 Commits 4 Files Changed 1
+8 -12
lars.winzer commented 2026-03-18 18:22:22 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Multiple changes to the checkstyle.xml file have been made, to align Checkstyles detections with the one of Spotless.

  1. Changed the parameters of the ImportOrder module to match the Google Java Style Guide.
  2. Removed the Indentation Module, as Spotless has a generative way of calculating the spaces needed.
  3. Commenting on the change made to the LineLength Module (increase from 80 to 100)

Closes #2

Multiple changes to the `checkstyle.xml` file have been made, to align Checkstyles detections with the one of Spotless. 1. Changed the parameters of the ImportOrder module to match the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html). 2. Removed the Indentation Module, as Spotless has a generative way of calculating the spaces needed. 3. Commenting on the change made to the LineLength Module (increase from 80 to 100) Closes #2
lars.winzer (Migrated from git.scicore.unibas.ch) scheduled this pull request to auto merge when all checks succeed 2026-03-18 18:22:48 +01:00
lars.winzer commented 2026-03-18 18:23:46 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 3581406833

mentioned in commit 358140683356a058966013d714fe26c93cc659de
lars.winzer (Migrated from git.scicore.unibas.ch) merged commit 3581406833 into main 2026-03-18 18:23:46 +01:00
lars.winzer commented 2026-03-18 18:31:26 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !39

mentioned in merge request !39
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#194
Delete Branch "issue/2-inconsistency-of-linting-between-checkstyle-and-spotless"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?