University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Merge branch 'fix/55-user-can-login-multiple-times' into 'main'

Browse Source 
Prevent multiple logins by checking for existing user session

Closes #55

See merge request cs108-fs26/Gruppe-13!84
This commit was merged in pull request #240.
This commit is contained in:
Lars Simon Winzer
2026-04-07 14:25:12 +02:00
parent 8a2d0607f8 d4722989d9
commit 06c5e5ab83
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/login/LoginHandler.java
+15 -1
View File
@@ -4,20 +4,34 @@ import ch.unibas.dmi.dbis.cs108.casono.server.domain.user.User;
import ch.unibas.dmi.dbis.cs108.casono.server.domain.user.UserFactory; import ch.unibas.dmi.dbis.cs108.casono.server.domain.user.UserFactory;
import ch.unibas.dmi.dbis.cs108.casono.server.domain.user.UserRegistry; import ch.unibas.dmi.dbis.cs108.casono.server.domain.user.UserRegistry;
import ch.unibas.dmi.dbis.cs108.casono.server.network.command.execution.CommandHandler; import ch.unibas.dmi.dbis.cs108.casono.server.network.command.execution.CommandHandler;
import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.ErrorResponse;
import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.dispatcher.ResponseDispatcher; import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.dispatcher.ResponseDispatcher;
import java.util.Optional;
public class LoginHandler implements CommandHandler<LoginRequest> { public class LoginHandler implements CommandHandler<LoginRequest> {
private final ResponseDispatcher responseDispatcher; private final ResponseDispatcher responseDispatcher;
private final UserRegistry userRegistry;
private final UserFactory userFactory; private final UserFactory userFactory;
public LoginHandler(ResponseDispatcher responseDispatcher, UserRegistry userRegistry) { public LoginHandler(ResponseDispatcher responseDispatcher, UserRegistry userRegistry) {
this.responseDispatcher = responseDispatcher; this.responseDispatcher = responseDispatcher;
this.userRegistry = userRegistry;
this.userFactory = new UserFactory(userRegistry); this.userFactory = new UserFactory(userRegistry);
} }
@Override @Override
public void execute(LoginRequest request) { public void execute(LoginRequest request) {
User user = userFactory.create(request.getUsername(), request.getContext().sessionId()); Optional<User> existingUser = userRegistry.getBySessionId(request.getSessionId());
if (existingUser.isPresent()) {
responseDispatcher.dispatch(
new ErrorResponse(
request.getContext(),
"ALREADY_LOGGED_IN",
"This session is already associated with an active user."));
return;
}
User user = userFactory.create(request.getUsername(), request.getSessionId());
responseDispatcher.dispatch( responseDispatcher.dispatch(
new LoginResponse(request.getContext(), user.getName(), user.getId())); new LoginResponse(request.getContext(), user.getName(), user.getId()));
} }