University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

The user can login multiple times with the same session #55

New Issue
Closed
opened 2026-04-07 13:59:21 +02:00 by lars.winzer · 5 comments
lars.winzer commented 2026-04-07 13:59:21 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Bug Report

Environment

Summary

The is able to login multiple times with the same session. Leading to unpredictable behaviour.

Expected Behavior

The server should respond with a ErrorResponse to the second LOGIN request, informing the user that he is already logged in.

Actual Behavior

Another user is created and the user is successfully logged in.

Steps to Reproduce

  1. Establish connection to server
  2. Send first login request
  3. Send second login request
  4. The client recieved a OK for both requests

Stack Trace / Error Message

None

Possible Cause / Notes

Its not checked, if the Session is already associated with a user object.

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation for relevant information
  • I added relevant labels
## Bug Report <!--The reccommended type is: Issue--> ### Environment - **Branch & Commit:** main - 78e0599182b7788488dbe844061592005322c212 ### Summary The is able to login multiple times with the same session. Leading to unpredictable behaviour. ### Expected Behavior The server should respond with a ErrorResponse to the second LOGIN request, informing the user that he is already logged in. ### Actual Behavior Another user is created and the user is successfully logged in. ### Steps to Reproduce 1. Establish connection to server 2. Send first login request 3. Send second login request 4. The client recieved a OK for both requests ### Stack Trace / Error Message ``` None ``` ### Possible Cause / Notes Its not checked, if the Session is already associated with a user object. ### Checklist - [x] I reproduced the problem using the steps above - [x] I searched documentation for relevant information - [x] I added relevant labels
lars.winzer commented 2026-04-07 14:15:06 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-04-07 14:15:31 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch fix/55-user-can-login-multiple-times to address this issue

created branch [`fix/55-user-can-login-multiple-times`](/cs108-fs26/Gruppe-13/-/compare/main...fix%2F55-user-can-login-multiple-times) to address this issue
lars.winzer commented 2026-04-07 14:23:45 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !84

mentioned in merge request !84
lars.winzer commented 2026-04-07 14:25:12 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 06c5e5ab83

mentioned in commit 06c5e5ab83b6ab3eb4b1ab3a3b9b211d3fb6b6c7
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-07 14:25:13 +02:00
lars.winzer commented 2026-04-07 14:37:34 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 10m of time spent at 2026-04-07 12:00:00 +0200

added 10m of time spent at 2026-04-07 12:00:00 +0200
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label bug commands server user
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#55
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?