src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/lobby/join_lobby/JoinLobbyHandler.java

@@ -13,12 +13,10 @@ import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.dispatch
 /**
  * Handler for the `JOIN_LOBBY` command.
  *
- * <p>
+ * <p>Resolves the username from the session (requires {@link UserLoggedInCheck}), looks up the
- * Resolves the username from the session (requires {@link UserLoggedInCheck}),
+ * target lobby and attempts to add the user. On success an `+OK` response is dispatched; on failure
- * looks up the target lobby and attempts to add the user. On success an
+ * an appropriate {@link ErrorResponse} with one of the error codes `LOBBY_NOT_FOUND`,
- * `+OK` response is dispatched; on failure an appropriate {@link ErrorResponse}
+ * `USER_NOT_LOGGED_IN` or `LOBBY_FULL_OR_ALREADY_IN` is returned.
- * with one of the error codes `LOBBY_NOT_FOUND`, `USER_NOT_LOGGED_IN` or
- * `LOBBY_FULL_OR_ALREADY_IN` is returned.
  */
 public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> {
     private final LobbyManager lobbyManager;
@@ -27,10 +25,9 @@ public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> {
     /**
      * Create a new {@link JoinLobbyHandler}.
      *
-     * @param responseDispatcher dispatcher used to send responses back to the
+     * @param responseDispatcher dispatcher used to send responses back to the client
-     *                           client
+     * @param lobbyManager manager providing lobby state and operations
-     * @param lobbyManager       manager providing lobby state and operations
+     * @param userRegistry registry to resolve session -> user mappings
-     * @param userRegistry       registry to resolve session -> user mappings
      */
     public JoinLobbyHandler(
             ResponseDispatcher responseDispatcher,

src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/lobby/join_lobby/JoinLobbyParser.java

@@ -7,15 +7,14 @@ import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.request.accessor.
 /**
  * Parser for the `JOIN_LOBBY` command.
  *
- * <p>
+ * <p>Expected request parameters:
- * Expected request parameters:
+ *
  * <ul>
- * <li>`ID` (int) — numeric lobby identifier (required)
+ *   <li>`ID` (int) — numeric lobby identifier (required)
  * </ul>
  *
- * <p>
+ * <p>The parser builds a {@link JoinLobbyRequest} containing the parsed lobby id and the original
- * The parser builds a {@link JoinLobbyRequest} containing the parsed lobby id
+ * request context.
- * and the original request context.
  */
 public class JoinLobbyParser implements CommandParser<JoinLobbyRequest> {
     /**
@@ -26,7 +25,8 @@ public class JoinLobbyParser implements CommandParser<JoinLobbyRequest> {
      */
     @Override
     public JoinLobbyRequest parse(PrimitiveRequest primitiveRequest) {
-        RequestParameterAccessor accessor = new RequestParameterAccessor(primitiveRequest.parameters());
+        RequestParameterAccessor accessor =
+                new RequestParameterAccessor(primitiveRequest.parameters());
         int id = accessor.require("ID", Integer::parseInt);
         return new JoinLobbyRequest(primitiveRequest.context(), id);
     }

src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/lobby/join_lobby/JoinLobbyRequest.java

@@ -6,9 +6,8 @@ import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.request.RequestCo
 /**
  * Request data for the `JOIN_LOBBY` command.
  *
- * <p>
+ * <p>Contains the lobby id the client wants to join and inherits the {@link Request} contextual
- * Contains the lobby id the client wants to join and inherits the
+ * information.
- * {@link Request} contextual information.
  */
 public class JoinLobbyRequest extends Request {
     private final int id;
@@ -17,7 +16,7 @@ public class JoinLobbyRequest extends Request {
      * Create a new {@link JoinLobbyRequest}.
      *
      * @param context the request context
-     * @param id      numeric lobby id to join
+     * @param id numeric lobby id to join
      */
     public JoinLobbyRequest(RequestContext context, int id) {
         super(context);