University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Task: Add command JOIN_LOBBY #97

New Issue
Closed
opened 2026-04-11 16:29:48 +02:00 by jona.walpert · 10 comments
jona.walpert commented 2026-04-11 16:29:48 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Task

The reccommended type is: Task

Summary

Add command JOIN_LOBBY to allow a user to join a specific lobby.

Context

Request, CommandParser, Response and CommandHandler

Current Progress

  • JoinLobbyRequest
  • JoinLobbyParser
  • JoinLobbyHandler
  • Update protocol documentation
  • Write JavaDoc

Request

JOIN_LOBBY
  LOBBY_ID=5
END

Response

+OK
END

Notes

  • The server resolves the joining user from the session associated with the request; clients must be logged in (LOGIN) before calling JOIN_LOBBY.
  • The command no longer accepts USERNAME or PLAYER_ID . identity is server-side.

Checklist

  • I outlined checkpoints describing phases of my work related to this task
  • I added relevant labels
  • I linked to other issues or branches that must be completed first
## Task The reccommended type is: Task ### Summary Add command `JOIN_LOBBY` to allow a user to join a specific lobby. ### Context Request, CommandParser, Response and CommandHandler ### Current Progress * [x] JoinLobbyRequest * [x] JoinLobbyParser * [x] JoinLobbyHandler * [x] Update protocol documentation * [x] Write JavaDoc #### Request ``` JOIN_LOBBY LOBBY_ID=5 END ``` #### Response ``` +OK END ``` #### **Notes** - The server resolves the joining user from the session associated with the request; clients must be logged in (`LOGIN`) before calling `JOIN_LOBBY`. - The command no longer accepts `USERNAME` or `PLAYER_ID` . identity is server-side. ### Checklist * [x] I outlined checkpoints describing phases of my work related to this task * [x] I added relevant labels * [x] I linked to other issues or branches that must be completed first
jona.walpert commented 2026-04-11 16:29:48 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @jona.walpert

assigned to @jona.walpert
jona.walpert commented 2026-04-11 18:06:59 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !100

mentioned in merge request !100
jona.walpert commented 2026-04-11 18:09:46 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Update protocol documentation as completed

marked the checklist item **Update protocol documentation** as completed
jona.walpert commented 2026-04-11 18:33:07 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item JoinLobbyRequest as completed

marked the checklist item **JoinLobbyRequest** as completed
jona.walpert commented 2026-04-11 18:33:09 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item JoinLobbyParser as completed

marked the checklist item **JoinLobbyParser** as completed
jona.walpert commented 2026-04-11 18:33:10 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item JoinLobbyHandler as completed

marked the checklist item **JoinLobbyHandler** as completed
jona.walpert commented 2026-04-11 18:33:22 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

changed the description

changed the description
jona.walpert commented 2026-04-11 19:47:54 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Write JavaDoc as completed

marked the checklist item **Write JavaDoc** as completed
jona.walpert commented 2026-04-11 19:48:22 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !102

mentioned in merge request !102
jona.walpert commented 2026-04-11 19:49:58 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 66ee791342

mentioned in commit 66ee79134232314373369b7a51d66470deef6884
jona.walpert (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-11 19:49:58 +02:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label client commands game-engine network server
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#97
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?