University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Inconsistent visibility of ThrowingParser prevents use of typed overloads in CommandParsers #81

New Issue
Closed
opened 2026-04-10 11:20:37 +02:00 by jona.walpert · 5 comments
jona.walpert commented 2026-04-10 11:20:37 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Bug Report

Environment

  • Branch & Commit: main
  • Operating system: Widnwos
  • How was execution started (Gradle task / IDE debug / IDE run): IDE debug
  • Java version: 25
  • Gradle version: 9.3.1

Summary

The ThrowingParser interface is not declared as public. This prevents classes in other packages (such as Command Parsers) from using the public methods of the RequestParameterAccessor class that utilize this type in their method signatures.

Expected Behavior

According to the project documentation you should be able to use typed overloads like accessor.require("KEY", Integer::parseInt) to avoid manual exception handling within the parsers.

Actual Behavior

The Java compiler fails with the following error:

The type ThrowingParser from the descriptor computed for the target context is not visible here.

Steps to Reproduce

  • Create a new Command Parser in a package outside of ...accessor (e.g., ch.unibas.dmi.dbis.cs108.casono.server.app.commands.raise).
  • Attempt to call the method RequestParameterAccessor.require(String, ThrowingParser<T>) using a method reference like Integer::parseInt

Stack Trace / Error Message

The type ThrowingParser<Integer> from the descriptor computed for the target context is not visible here.

Possible Cause / Notes

The access modifier public is missing from the ThrowingParser interface declaration in RequestParameterAccessor.java. Since this interface serves as a formal parameter in a public API method, it must also be publicly accessible so that the method reference (target typing) can be resolved in the caller's context.

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation for relevant information
  • I added relevant labels
## Bug Report <!--The reccommended type is: Issue--> ### Environment - **Branch & Commit: main** - **Operating system: Widnwos** - **How was execution started (Gradle task / IDE debug / IDE run): IDE debug** - **Java version:** 25 - **Gradle version**: 9.3.1 ### Summary The ThrowingParser interface is not declared as public. This prevents classes in other packages (such as Command Parsers) from using the public methods of the RequestParameterAccessor class that utilize this type in their method signatures. ### Expected Behavior According to the project documentation you should be able to use typed overloads like accessor.require("KEY", Integer::parseInt) to avoid manual exception handling within the parsers. ### Actual Behavior The Java compiler fails with the following error: `The type ThrowingParser from the descriptor computed for the target context is not visible here`. ### Steps to Reproduce * Create a new Command Parser in a package outside of `...accessor` (e.g., `ch.unibas.dmi.dbis.cs108.casono.server.app.commands.raise`). * Attempt to call the method `RequestParameterAccessor.require(String, ThrowingParser<T>)` using a method reference like `Integer::parseInt` ### Stack Trace / Error Message ``` The type ThrowingParser<Integer> from the descriptor computed for the target context is not visible here. ``` ### Possible Cause / Notes The access modifier `public` is missing from the `ThrowingParser` interface declaration in `RequestParameterAccessor.java`. Since this interface serves as a formal parameter in a public API method, it must also be publicly accessible so that the method reference (target typing) can be resolved in the caller's context. ### Checklist - [x] I reproduced the problem using the steps above - [x] I searched documentation for relevant information - [x] I added relevant labels
jona.walpert commented 2026-04-10 11:20:37 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-04-10 11:24:40 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch fix/81-incorrect-visibility-of-throwingparser to address this issue

created branch [`fix/81-incorrect-visibility-of-throwingparser`](/cs108-fs26/Gruppe-13/-/compare/main...fix%2F81-incorrect-visibility-of-throwingparser) to address this issue
lars.winzer commented 2026-04-10 11:25:23 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 3m of time spent at 2026-04-10 12:00:00 +0200

added 3m of time spent at 2026-04-10 12:00:00 +0200
lars.winzer commented 2026-04-10 11:26:02 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !94

mentioned in merge request !94
lars.winzer commented 2026-04-10 11:30:23 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 3ee1e63577

mentioned in commit 3ee1e6357748f3899428e0abada9029bb10d4367
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-10 11:30:23 +02:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label bug commands game-engine server
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#81
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?