University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

SessionReader does not explicitly catch MissingParameterException leading to meaningless INTERNAL_ERROR response #46

New Issue
Closed
opened 2026-04-02 13:32:51 +02:00 by lars.winzer · 8 comments
lars.winzer commented 2026-04-02 13:32:51 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Bug Report

Environment

  • Branch & Commit: 07587340d4
  • Others are not applicable

Summary

The SessionReader does not handle the MissingParameterException, while the CommandParser has no way to do so.

Expected Behavior

The SessionReader should catch this exception and respond with an ErrorResponse .

Actual Behavior

The Exception is unhandled and an ErrorResponse with the INTERNAL_ERROR code is sent to the client. Information about why the error occured is herby lost.

Steps to Reproduce

  1. Checkout 07587340d4
  2. Start the server
  3. Send an CHECK_USERNAME request to the server missing the USERNAME parameter
  4. Observe the recieved INTERNAL_ERROR response and the trace in the server log

Stack Trace / Error Message

Unexpected RuntimeException occured
ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.request.accessor.MissingParameterException: Required parameter with key 'USERNAME' is missing.
        at ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.request.accessor.RequestParameterAccessor.require(RequestParameterAccessor.java:40)
        at ch.unibas.dmi.dbis.cs108.casono.server.app.commands.check_nick.CheckUsernameParser.parse(CheckUsernameParser.java:11)
        at ch.unibas.dmi.dbis.cs108.casono.server.app.commands.check_nick.CheckUsernameParser.parse(CheckUsernameParser.java:1)
        at ch.unibas.dmi.dbis.cs108.casono.server.network.command.parsing.CommandParserDispatcher.parse(CommandParserDispatcher.java:36)
        at ch.unibas.dmi.dbis.cs108.casono.server.network.sessions.SessionReader.run(SessionReader.java:68)
        at java.base/java.lang.VirtualThread.run(VirtualThread.java:456)

Possible Cause / Notes

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation for relevant information
  • I added relevant labels
## Bug Report <!--The reccommended type is: Issue--> ### Environment - **Branch & Commit:** 07587340d411c2f59a2c91d98400e837079dffcb - Others are not applicable ### Summary The SessionReader does not handle the `MissingParameterException`, while the `CommandParser` has no way to do so. ### Expected Behavior The SessionReader should catch this exception and respond with an `ErrorResponse` . ### Actual Behavior The Exception is unhandled and an `ErrorResponse` with the `INTERNAL_ERROR` code is sent to the client. Information about why the error occured is herby lost. ### Steps to Reproduce 1. Checkout 07587340d411c2f59a2c91d98400e837079dffcb 2. Start the server 3. Send an `CHECK_USERNAME` request to the server missing the `USERNAME` parameter 4. Observe the recieved `INTERNAL_ERROR` response and the trace in the server log ### Stack Trace / Error Message ``` Unexpected RuntimeException occured ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.request.accessor.MissingParameterException: Required parameter with key 'USERNAME' is missing. at ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.request.accessor.RequestParameterAccessor.require(RequestParameterAccessor.java:40) at ch.unibas.dmi.dbis.cs108.casono.server.app.commands.check_nick.CheckUsernameParser.parse(CheckUsernameParser.java:11) at ch.unibas.dmi.dbis.cs108.casono.server.app.commands.check_nick.CheckUsernameParser.parse(CheckUsernameParser.java:1) at ch.unibas.dmi.dbis.cs108.casono.server.network.command.parsing.CommandParserDispatcher.parse(CommandParserDispatcher.java:36) at ch.unibas.dmi.dbis.cs108.casono.server.network.sessions.SessionReader.run(SessionReader.java:68) at java.base/java.lang.VirtualThread.run(VirtualThread.java:456) ``` ### Possible Cause / Notes <!--Optional: your own hypothesis about the root cause--> ### Checklist - [x] I reproduced the problem using the steps above - [x] I searched documentation for relevant information - [x] I added relevant labels
lars.winzer commented 2026-04-02 13:33:20 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

This issue was discovered while implementing the CHECK_USERNAME request in #39

This issue was discovered while implementing the `CHECK_USERNAME` request in #39
lars.winzer commented 2026-04-02 13:33:58 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch fix/46-sessionreader-catch-missingparameterexception to address this issue

created branch [`fix/46-sessionreader-catch-missingparameterexception`](/cs108-fs26/Gruppe-13/-/compare/main...fix%2F46-sessionreader-catch-missingparameterexception) to address this issue
lars.winzer commented 2026-04-02 13:34:00 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-04-02 13:47:05 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !73

mentioned in merge request !73
lars.winzer commented 2026-04-02 13:48:27 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 95e3474c8c

mentioned in commit 95e3474c8c1087a804d9b213b57d49eaee248489
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-02 13:48:28 +02:00
lars.winzer commented 2026-04-02 13:48:58 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 8m of time spent at 2026-04-02 12:00:00 +0200

added 8m of time spent at 2026-04-02 12:00:00 +0200
lars.winzer commented 2026-04-02 13:49:20 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

changed the description

changed the description
lars.winzer commented 2026-04-02 15:09:07 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !75

mentioned in merge request !75
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label bug network server
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#46
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?