University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Make Response use RequestContext as planned #34

New Issue
Closed
opened 2026-03-31 19:56:05 +02:00 by lars.winzer · 4 comments
lars.winzer commented 2026-03-31 19:56:05 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Bug Report

Environment

  • Branch & Commit: 56667bfb12
  • Others are not applicable for this issue

Summary

Besides the changes made in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/work_items/12 with the addition of the RequestContext , this change was never used in the Response for which the change was originally made.

Expected Behavior

The Responses should be instanciable by providing the RequestContext instead of manually both the sessionId and requestId.

Actual Behavior

The user is required to extract the values from the RequestContext and provide them manually to the Request.

Steps to Reproduce

Not Applicable.

Stack Trace / Error Message

Not applicable

Possible Cause / Notes

Not applicable

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation for relevant information
  • I added relevant labels
## Bug Report <!--The reccommended type is: Issue--> ### Environment - **Branch & Commit:** 56667bfb1205bfbf204c2eefe832838f32da559d - Others are not applicable for this issue ### Summary Besides the changes made in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/work_items/12 with the addition of the `RequestContext` , this change was never used in the Response for which the change was originally made. ### Expected Behavior The Responses should be instanciable by providing the `RequestContext` instead of manually both the `sessionId` and `requestId`. ### Actual Behavior The user is required to extract the values from the `RequestContext` and provide them manually to the `Request`. ### Steps to Reproduce Not Applicable. ### Stack Trace / Error Message ``` Not applicable ``` ### Possible Cause / Notes Not applicable ### Checklist - [x] ~~I reproduced the problem using the steps above~~ - [x] ~~I searched documentation for relevant information~~ - [x] I added relevant labels
lars.winzer commented 2026-03-31 19:56:25 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch feat/34-make-response-use-requestcontext to address this issue

created branch [`feat/34-make-response-use-requestcontext`](/cs108-fs26/Gruppe-13/-/compare/main...feat%2F34-make-response-use-requestcontext) to address this issue
lars.winzer commented 2026-03-31 20:19:32 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-03-31 20:42:12 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !64

mentioned in merge request !64
lars.winzer commented 2026-03-31 20:50:08 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 6736345cbe

mentioned in commit 6736345cbeaabae07e38429bfe49dfe793bf74c3
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-03-31 20:50:08 +02:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label bug network server
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#34
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?