University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Create utility class to provide easy access to List of Parameters #21

New Issue
Closed
opened 2026-03-27 17:22:07 +01:00 by lars.winzer · 8 comments
lars.winzer commented 2026-03-27 17:22:07 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Feature Request

Summary

Utility class to provide easy access via methods to list of parameters wrapped in PrimitiveRequest, used in each implementation of the CommandParser.

Required workarround

Each implementation of the CommandParser needs to repeatedly:

  1. Check if the required parameter are present
  2. Convert from String to another type

If one of both conditions aren't met, the processing must be aborted and the client must be informed.

Description

Special RequestParameterAccessor class taking the list of parameters during instantiation.

This class should provide methods to get a value based on its key. A default value can be provided to be returned when no parameter is found.

Another overloaded variant could allow to provide a function (e.g. Integer::fromString ) to implicitly convert to the desired type.

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation docs for relevant information
  • I added relevant labels
## Feature Request <!--The reccommended type is: Task--> ### Summary Utility class to provide easy access via methods to list of parameters wrapped in `PrimitiveRequest`, used in each implementation of the `CommandParser`. ### Required workarround Each implementation of the CommandParser needs to repeatedly: 1. Check if the required parameter are present 2. Convert from String to another type If one of both conditions aren't met, the processing must be aborted and the client must be informed. ### Description Special `RequestParameterAccessor` class taking the list of parameters during instantiation. This class should provide methods to get a value based on its key. A default value can be provided to be returned when no parameter is found. Another overloaded variant could allow to provide a function (e.g. `Integer::fromString` ) to implicitly convert to the desired type. ### Checklist - [x] ~~I reproduced the problem using the steps above~~ - [x] ~~I searched documentation docs for relevant information~~ - [x] I added relevant labels
lars.winzer commented 2026-03-30 11:37:26 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-03-30 11:38:17 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch feat/21-requestparameteraccessor to address this issue

created branch [`feat/21-requestparameteraccessor`](/cs108-fs26/Gruppe-13/-/compare/main...feat%2F21-requestparameteraccessor) to address this issue
lars.winzer commented 2026-03-30 13:04:03 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 20m of time spent at 2026-03-30 12:00:00 +0200

added 20m of time spent at 2026-03-30 12:00:00 +0200
lars.winzer commented 2026-03-30 13:04:39 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 1h of time spent at 2026-03-30 12:00:00 +0200

added 1h of time spent at 2026-03-30 12:00:00 +0200
lars.winzer commented 2026-03-30 13:22:19 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !52

mentioned in merge request !52
lars.winzer commented 2026-03-30 13:25:47 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch chore/21-fix-style to address this issue

created branch [`chore/21-fix-style`](/cs108-fs26/Gruppe-13/-/compare/main...chore%2F21-fix-style) to address this issue
lars.winzer commented 2026-03-30 13:30:24 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !53

mentioned in merge request !53
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-03-30 13:31:56 +02:00
lars.winzer commented 2026-03-30 13:31:57 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Used https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/53 to fix line length formatting violations introduced in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/52

Used https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/53 to fix line length formatting violations introduced in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/52
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label enhancement network server
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#21
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?