University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Create CommandRouter and CommandHandler to execute request #14

New Issue
Closed
opened 2026-03-24 18:57:48 +01:00 by lars.winzer · 12 comments
lars.winzer commented 2026-03-24 18:57:48 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Task

Summary

The task of the CommandRouter is it to look up a matching CommandHandler based on the type of the Request it recieves.

The CommandHandler then executes the Request and creates an Response that is then send back to the client with the components created in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/work_items/8.

I thought I have already created the CommandHandler in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/32. For some reason I did implement the right thing but wrote the wrong name in the title and discription of the MR. Weird.

Anyways, the implementation of the (actual) CommandRouter and CommandHandler should be rather straight forward. It follows the principle used in the CommandParserDispatcher and CommandParser.

Context

CommandRouter, CommandHandler

Definition of Done

  • Implement CommandHandler interface and CommandRouter class
  • Create instance of CommandRouter at startup of server
  • Add router field to SessionManager and SessionReader
  • Make SessionReader call route-method on CommandRouter instance

Checklist

  • Linked to other issues or branches that must be completed first?
## Task ### Summary The task of the CommandRouter is it to look up a matching CommandHandler based on the type of the Request it recieves. The CommandHandler then executes the Request and creates an Response that is then send back to the client with the components created in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/work_items/8. --- I thought I have already created the `CommandHandler` in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/32. For some reason I did implement the right thing but wrote the wrong name in the title and discription of the MR. Weird. Anyways, the implementation of the (actual) `CommandRouter` and `CommandHandler` should be rather straight forward. It follows the principle used in the `CommandParserDispatcher` and `CommandParser`. ### Context CommandRouter, CommandHandler ### Definition of Done - [x] Implement `CommandHandler` interface and `CommandRouter` class - [x] Create instance of `CommandRouter` at startup of server - [x] Add router field to `SessionManager` and `SessionReader` - [x] Make SessionReader call route-method on `CommandRouter` instance ### Checklist - [x] Linked to other issues or branches that must be completed first?
lars.winzer commented 2026-03-24 18:58:01 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked this task as related to #13

marked this task as related to #13
lars.winzer commented 2026-03-24 18:58:03 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Linked to other issues or branches that must be completed first? as completed

marked the checklist item **Linked to other issues or branches that must be completed first?** as completed
lars.winzer commented 2026-03-26 16:46:47 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-03-26 16:47:10 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch feat/14-commandrouter-and-commandhandler to address this issue

created branch [`feat/14-commandrouter-and-commandhandler`](/cs108-fs26/Gruppe-13/-/compare/main...feat%2F14-commandrouter-and-commandhandler) to address this issue
lars.winzer commented 2026-03-26 18:11:30 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Implement CommandHandler interface and CommandRouter class as completed

marked the checklist item **Implement CommandHandler interface and CommandRouter class** as completed
lars.winzer commented 2026-03-26 18:11:31 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Create instance of CommandRouter at startup of server as completed

marked the checklist item **Create instance of CommandRouter at startup of server** as completed
lars.winzer commented 2026-03-26 18:11:33 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Add router field to SessionManager and SessionReader as completed

marked the checklist item **Add router field to SessionManager and SessionReader** as completed
lars.winzer commented 2026-03-26 18:11:43 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Make SessionReader call route-method on CommandRouter instance as completed

marked the checklist item **Make SessionReader call route\-method on CommandRouter instance** as completed
lars.winzer commented 2026-03-26 18:14:34 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 1h 25m of time spent at 2026-03-26 12:00:00 +0100

added 1h 25m of time spent at 2026-03-26 12:00:00 +0100
lars.winzer commented 2026-03-26 18:16:14 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

One word: Generics in Java are weird.

And as soon as you run into type erasure ... lets leave it at that.

One word: Generics in Java are weird. And as soon as you run into type erasure ... lets leave it at that.
lars.winzer commented 2026-03-26 18:22:20 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !50

mentioned in merge request !50
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-03-26 18:24:18 +01:00
lars.winzer commented 2026-03-26 18:24:19 +01:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Specified #17 to be closed instead of this one in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/50

Specified #17 to be closed instead of this one in https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/50
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label server task
Milestone
No items
No Milestone Milestone 4
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#14
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?