University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Write unit tests for SessionDisconnectJob #134

New Issue
Closed
opened 2026-04-27 00:19:15 +02:00 by lars.winzer · 8 comments
lars.winzer commented 2026-04-27 00:19:15 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Task

Summary

The SessionDisconnectJob, whose purpose it is to disconnect sessions that have reaced the set timeout, needs to be tested.

Context

SessionDisconnectJob, Unit Tests

Current Progress

  • Write unit tests for SessionDisconnectJob

Notes

None

Checklist

  • I outlined checkpoints describing phases of my work related to this task
  • I added relevant labels
  • I linked to other issues or branches that must be completed first
## Task <!--The reccommended type is: Task--> ### Summary The SessionDisconnectJob, whose purpose it is to disconnect sessions that have reaced the set timeout, needs to be tested. ### Context SessionDisconnectJob, Unit Tests ### Current Progress - [x] Write unit tests for SessionDisconnectJob ### Notes None ### Checklist - [x] I outlined checkpoints describing phases of my work related to this task - [x] I added relevant labels - [x] I linked to other issues or branches that must be completed first
lars.winzer commented 2026-04-27 00:19:38 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch feat/134-write-unit-tests-for-sessiondisconnectjob to address this issue

created branch [`feat/134-write-unit-tests-for-sessiondisconnectjob`](/cs108-fs26/Gruppe-13/-/compare/main...feat%2F134-write-unit-tests-for-sessiondisconnectjob) to address this issue
lars.winzer commented 2026-04-27 00:22:19 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

added 30m of time spent at 2026-04-27 12:00:00 +0200

added 30m of time spent at 2026-04-27 12:00:00 +0200
lars.winzer commented 2026-04-27 00:23:48 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

These tests are not the best unit tests I wrote, mainly because the job integrates into many neighbouring components.

Nevertheless the combination of both tests should still provide a good coverage of potential bugs.

These tests are not the best unit tests I wrote, mainly because the job integrates into many neighbouring components. Nevertheless the combination of both tests should still provide a good coverage of potential bugs.
lars.winzer commented 2026-04-27 00:24:58 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !160

mentioned in merge request !160
lars.winzer commented 2026-04-27 00:38:35 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 71f2d3c2ce

mentioned in commit 71f2d3c2cee4904b26ffef4b1daee124091432f6
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-27 00:38:36 +02:00
lars.winzer commented 2026-04-27 00:59:59 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-04-27 01:00:25 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

marked the checklist item Write unit tests for SessionDisconnectJob as completed

marked the checklist item **Write unit tests for SessionDisconnectJob** as completed
lars.winzer commented 2026-04-27 01:09:42 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in task #111

mentioned in task #111
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label network server task unit-test
Milestone
No items
No Milestone Milestone 5
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?