University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Number-only keys should be disallowed #127

New Issue
Open
opened 2026-04-25 14:13:35 +02:00 by lars.winzer · 2 comments
lars.winzer commented 2026-04-25 14:13:35 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Bug Report

Environment

  • Branch & Commit: main - d4a3ebb487
  • Operating system: macOS
  • How was execution started (Gradle task / IDE debug / IDE run): Not applicable
  • Java version: 25
  • Gradle version: 9.3.1

Summary

While finalizing the changes in #4 I noticed that number-only keys are allowed.

While the protocol document states that

Only a-z, A-Z, 0-9 are allowed in keys.

meaning that number-only keys are allowed too.

However, they should be not.

Expected Behavior

The TokenClassifier should thrown an exception, informing that number-only keys are not allowed.

Actual Behavior

Following the outlined (current) conventions, number-only keys are allowed.

Steps to Reproduce

  1. Tokenize and Classify a string containing a number-only key (ex. CMD 42=abc )
  2. Observe that the Classifier does not throw an exception.

Stack Trace / Error Message

None

Possible Cause / Notes

None.

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation for relevant information
  • I added relevant labels
## Bug Report <!--The reccommended type is: Issue--> ### Environment - **Branch & Commit:** main - d4a3ebb487edd3488026db9a8594f8db88e1fec6 - **Operating system:** macOS - **How was execution started (Gradle task / IDE debug / IDE run):** Not applicable - **Java version:** `25` - **Gradle version**: `9.3.1` ### Summary While finalizing the changes in #4 I noticed that number-only keys are allowed. While the [protocol document](https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/blob/22d742d614d97656138b5352a283da7792bf1265/documents/docs/our-protocol.md) states that > Only a-z, A-Z, 0-9 are allowed in keys. meaning that number-only keys are allowed too. However, they should be not. ### Expected Behavior The TokenClassifier should thrown an exception, informing that number-only keys are not allowed. ### Actual Behavior Following the outlined (current) conventions, number-only keys are allowed. ### Steps to Reproduce 1. Tokenize and Classify a string containing a number-only key (ex. `CMD 42=abc` ) 2. Observe that the Classifier does not throw an exception. ### Stack Trace / Error Message ``` None ``` ### Possible Cause / Notes None. ### Checklist - [x] I reproduced the problem using the steps above - [x] I searched documentation for relevant information - [x] I added relevant labels
lars.winzer commented 2026-04-25 14:13:35 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-04-27 01:11:37 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Issue will be moved to Milestone 6

Issue will be moved to Milestone 6
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label bug network server
Milestone
No items
No Milestone Milestone 6
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#127
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?