University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Missing key ("CMD =VALUE") is not detected by TokenClassifier #126

New Issue
Closed
opened 2026-04-25 13:37:50 +02:00 by lars.winzer · 4 comments
lars.winzer commented 2026-04-25 13:37:50 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Bug Report

Environment

  • Branch & Commit: main - d4a3ebb487
  • Operating system: macOS
  • How was execution started (Gradle task / IDE debug / IDE run): Not applicable
  • Java version: 25
  • Gradle version: 9.3.1

Summary

While creating the unit tests for the tokenizer (#4) I discovered that the following statement is valid:

CMD =VALUE

Even though no KEY is associated with the VALUE.

Expected Behavior

The TokenClassifier should throw a TokenizerException with the "Expected KEY before '='" message.

Actual Behavior

Its considered valid, even though it does not conform to our protocol specification.

Steps to Reproduce

  1. Let the Tokenizer tokenize the CMD =VALUE string
  2. Let the TokenClassifier classify the list of RawTokens
  3. Observe that no exception is thrown

Stack Trace / Error Message

None

Possible Cause / Notes

None

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation for relevant information
  • I added relevant labels
## Bug Report <!--The reccommended type is: Issue--> ### Environment - **Branch & Commit:** main **-** d4a3ebb487edd3488026db9a8594f8db88e1fec6 - **Operating system:** macOS - **How was execution started (Gradle task / IDE debug / IDE run):** Not applicable - **Java version:** `25` - **Gradle version**: `9.3.1` ### Summary While creating the unit tests for the tokenizer (#4) I discovered that the following statement is valid: ``` CMD =VALUE ``` Even though no `KEY` is associated with the `VALUE`. ### Expected Behavior The TokenClassifier should throw a TokenizerException with the "Expected KEY before '='" message. ### Actual Behavior Its considered valid, even though it does not conform to our protocol specification. ### Steps to Reproduce 1. Let the Tokenizer tokenize the `CMD =VALUE` string 2. Let the TokenClassifier classify the list of RawTokens 3. Observe that no exception is thrown ### Stack Trace / Error Message ``` None ``` ### Possible Cause / Notes None ### Checklist - [x] I reproduced the problem using the steps above - [x] I searched documentation for relevant information - [x] I added relevant labels
lars.winzer commented 2026-04-25 13:37:50 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @lars.winzer

assigned to @lars.winzer
lars.winzer commented 2026-04-25 14:14:15 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

created branch fix/126-missing-key-is-not-detected-by-tokenclassifier to address this issue

created branch [`fix/126-missing-key-is-not-detected-by-tokenclassifier`](/cs108-fs26/Gruppe-13/-/compare/main...fix%2F126-missing-key-is-not-detected-by-tokenclassifier) to address this issue
lars.winzer commented 2026-04-25 14:31:05 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in merge request !150

mentioned in merge request !150
lars.winzer commented 2026-04-25 14:33:13 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

mentioned in commit 5ded42abe6

mentioned in commit 5ded42abe6adf5c569099ab029517922387469ac
lars.winzer (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-25 14:33:14 +02:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label bug network server
Milestone
No items
No Milestone Milestone 5
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#126
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?