University-of-Basel-Studentprojects/Programmierprojekt
Archived
1
0
Fork 0
Code Issues 17 Pull Requests Actions Wiki Activity

Duplicated code for check if lobby exists #121

New Issue
Closed
opened 2026-04-22 12:32:14 +02:00 by lars.winzer · 2 comments
lars.winzer commented 2026-04-22 12:32:14 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Bug Report

Environment

  • Branch & Commit: main - 028c3adb0d
  • Operating system: Not applicable
  • How was execution started (Gradle task / IDE debug / IDE run): Not applicable
  • Java version: 25
  • Gradle version: 9.3.1

Summary

The check for if the lobby exists

Expected Behavior

A pre-execution check should be used.

Actual Behavior

The code is duplicated across multiple CommandHandler in the following files:

Steps to Reproduce

Not applicable

Stack Trace / Error Message

Not applicable

Possible Cause / Notes

Not applicable

Checklist

  • I reproduced the problem using the steps above
  • I searched documentation for relevant information
  • I added relevant labels
## Bug Report <!--The reccommended type is: Issue--> ### Environment - **Branch & Commit:** main - 028c3adb0d9bc6292fa5f6aba155704b303fc46e - **Operating system:** Not applicable - **How was execution started (Gradle task / IDE debug / IDE run):** Not applicable - **Java version:** `25` - **Gradle version**: `9.3.1` ### Summary The check for if the lobby exists ### Expected Behavior A pre-execution check should be used. ### Actual Behavior The code is duplicated across multiple `CommandHandler` in the following files: * [PlayerBetHandler](https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/blob/main/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/game/bet/PlayerBetHandler.java#L77-88) * [PlayerCallHandler](https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/blob/main/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/game/call/PlayerCallHandler.java#L65-76) * [PlayerFoldHandler](https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/blob/main/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/game/fold/PlayerFoldHandler.java#L65-76) * [PlayerRaiseHandler](https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/blob/main/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/app/commands/game/raise/PlayerRaiseHandler.java#L79-90) ### Steps to Reproduce Not applicable ### Stack Trace / Error Message ``` Not applicable ``` ### Possible Cause / Notes Not applicable ### Checklist - [x] I reproduced the problem using the steps above - [x] I searched documentation for relevant information - [x] I added relevant labels
lars.winzer commented 2026-04-22 12:32:14 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

assigned to @jona.walpert

assigned to @jona.walpert
jona.walpert (Migrated from git.scicore.unibas.ch) closed this issue 2026-04-24 13:28:14 +02:00
jona.walpert commented 2026-04-24 13:28:15 +02:00 (Migrated from git.scicore.unibas.ch)
Copy Link
Copy Source

Closed with !146

Closed with [!146](https://git.scicore.unibas.ch/cs108-fs26/Gruppe-13/-/merge_requests/146)
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
achievement
Tasks related to milestone achievements
 bug
Issues related to programming errors on both client and server
 ci
Issues related to problems with the gitlab ci (incorrect or missing jobs)
 client
Issues (To-Dos and tasks) related to the client
 commands
Issues and tasks related to commands and thier infrastructure (CommandHandler, CommandParser, ...)
 documentation
Issues related to the documentation (for new or unclear, incorrect or incomplete entries)
 enhancement
Issues related to enhancements (also known as feature-requests)
 game-engine
Issues related to the game engine (incorrect state transitions or move validations)
 linting
Issues related to linting i.e. false detections, too generous linting, ...
 messages
Issues and tasks related to the messages and chats
 network
Issues and tasks related to the network (SessionReader / SessionWriter, Parser, ResponseBody, ...)
 outreach
Issues and tasks related to the outreach website and everything directly related to it
 server
Issues (To-Dos and tasks) related to the server
 task
Issues outlining and discussing a general task or implementation
 templates
Issues related to GitLab templates
 ui
Issues and tasks related to the client-side ui
 unit-test
Issues related to missing or already planned unit tests
 user
Issues and tasks related to the user management
No Label bug server
Milestone
No items
No Milestone Milestone 5
Assignees
Clear assignees
lars-winzer (Lars Winzer)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: University-of-Basel-Studentprojects/Programmierprojekt#121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?