From f841eecb93de7fe690e333a7a32f96b0ca6f938d Mon Sep 17 00:00:00 2001
From: Lars Simon Winzer <lars.winzer@stud.unibas.ch>
Date: Mon, 30 Mar 2026 14:13:29 +0200
Subject: [PATCH] Fix: disallow failure for checkstyle job for merge requests

---
 .gitlab-ci.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 04bb8bd..3c78f55 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -22,7 +22,7 @@ stages:
 .on-mr: &on-mr
   rules:
     - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
-      allow_failure: true   # deactivate after all issues (shown by checkstyle) have been resolved
+      allow_failure: false
 
 # Jobs
 checkstyle:
@@ -48,7 +48,7 @@ checkstyle-mr:
     image: gradle:9.3.1-jdk25
     script:
         - gradle checkstyleMain checkstyleTest
-    allow_failure: true
+    allow_failure: false
     artifacts:
         when: always
         paths:
@@ -66,6 +66,7 @@ checkstyle-report:
         - job: checkstyle-mr
           artifacts: true
           optional: true
+    when: always
     rules:
         - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
     script: