From f79f7f0ae2aeae24335348d71dc24139c8cb04b9 Mon Sep 17 00:00:00 2001 From: Lars Simon Winzer Date: Fri, 20 Mar 2026 16:56:03 +0100 Subject: [PATCH] Add: Useful information to log statement to ease debugging --- .../cs108/casono/server/network/sessions/SessionReader.java | 5 +++-- .../cs108/casono/server/network/sessions/SessionWriter.java | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionReader.java b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionReader.java index 45e83a4..7c2a6c7 100644 --- a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionReader.java +++ b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionReader.java @@ -31,8 +31,9 @@ public class SessionReader implements Runnable { @Override public void run() { while (!Thread.currentThread().isInterrupted()) { + RawPacket rawPacket = null; try { - RawPacket rawPacket = transport.read(); + rawPacket = transport.read(); logger.debug("Recieved: {}", rawPacket); PrimitiveRequest primitiveRequest = ProtocolParser.parse(rawPacket); @@ -42,7 +43,7 @@ public class SessionReader implements Runnable { eventBus.publish(new DisconnectEvent(session.getId())); break; } catch (TokenizerException | ProtocolParserException e) { - logger.error("Error occured while parsing request", e); + logger.error("Error occured while parsing request. RawPacket: {}", rawPacket, e); // TODO: Send error response to client } catch (IOException e) { diff --git a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionWriter.java b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionWriter.java index 714745c..7d85fec 100644 --- a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionWriter.java +++ b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/network/sessions/SessionWriter.java @@ -23,12 +23,13 @@ public class SessionWriter implements Runnable { public void run() { while (!Thread.currentThread().isInterrupted()) { + RawPacket packet = null; try { PrimitiveResponse response = queue.take(); - RawPacket packet = new RawPacket(response.requestId(), response.payload()); + packet = new RawPacket(response.requestId(), response.payload()); transport.write(packet); } catch (IOException e) { - logger.error("Unexpected exception while writing to transport", e); + logger.error("Unexpected exception while writing to transport. RawPacket: {}", packet, e); } catch (InterruptedException e) { logger.warn("Thread got interrupted", e); break;