Feat: Log JOIN_LOBBY requests and joins

This commit is contained in:
Jona Walpert
2026-04-12 13:12:55 +02:00
parent 1dcf628d2c
commit e43732c520
@@ -9,6 +9,8 @@ import ch.unibas.dmi.dbis.cs108.casono.server.network.command.execution.CommandH
import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.ErrorResponse; import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.ErrorResponse;
import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.OkResponse; import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.OkResponse;
import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.dispatcher.ResponseDispatcher; import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.dispatcher.ResponseDispatcher;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
/** /**
* Handler for the `JOIN_LOBBY` command. * Handler for the `JOIN_LOBBY` command.
@@ -21,6 +23,7 @@ import ch.unibas.dmi.dbis.cs108.casono.server.network.protocol.response.dispatch
public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> { public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> {
private final LobbyManager lobbyManager; private final LobbyManager lobbyManager;
private final UserRegistry userRegistry; private final UserRegistry userRegistry;
private static final Logger LOGGER = LogManager.getLogger(JoinLobbyHandler.class);
/** /**
* Create a new {@link JoinLobbyHandler}. * Create a new {@link JoinLobbyHandler}.
@@ -46,9 +49,17 @@ public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> {
*/ */
@Override @Override
public void execute(JoinLobbyRequest request) { public void execute(JoinLobbyRequest request) {
LOGGER.info(
"JOIN_LOBBY request: session={}, lobbyId={}",
request.getContext().sessionId(),
request.getId());
LobbyId lid = LobbyId.of(request.getId()); LobbyId lid = LobbyId.of(request.getId());
var lobby = lobbyManager.getLobby(lid); var lobby = lobbyManager.getLobby(lid);
if (lobby == null) { if (lobby == null) {
LOGGER.warn(
"JOIN_LOBBY: Lobby {} not found (session={})",
request.getId(),
request.getContext().sessionId());
responseDispatcher.dispatch( responseDispatcher.dispatch(
new ErrorResponse(request.getContext(), "LOBBY_NOT_FOUND", "Lobby not found")); new ErrorResponse(request.getContext(), "LOBBY_NOT_FOUND", "Lobby not found"));
return; return;
@@ -56,7 +67,9 @@ public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> {
var maybeUser = userRegistry.getBySessionId(request.getContext().sessionId()); var maybeUser = userRegistry.getBySessionId(request.getContext().sessionId());
if (maybeUser.isEmpty()) { if (maybeUser.isEmpty()) {
// UserLoggedInCheck should normally prevent this; keep safe fallback LOGGER.warn(
"JOIN_LOBBY: No user associated with session {}",
request.getContext().sessionId());
responseDispatcher.dispatch( responseDispatcher.dispatch(
new ErrorResponse( new ErrorResponse(
request.getContext(), request.getContext(),
@@ -70,6 +83,10 @@ public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> {
boolean ok = lobbyManager.addPlayerToLobby(username, lid); boolean ok = lobbyManager.addPlayerToLobby(username, lid);
if (!ok) { if (!ok) {
LOGGER.warn(
"JOIN_LOBBY: User '{}' failed to join lobby {} (full or already in)",
username,
request.getId());
responseDispatcher.dispatch( responseDispatcher.dispatch(
new ErrorResponse( new ErrorResponse(
request.getContext(), request.getContext(),
@@ -78,6 +95,8 @@ public class JoinLobbyHandler extends CommandHandler<JoinLobbyRequest> {
return; return;
} }
LOGGER.info("User '{}' joined lobby {}", username, request.getId());
responseDispatcher.dispatch(new OkResponse(request.getContext())); responseDispatcher.dispatch(new OkResponse(request.getContext()));
} }
} }