From d8d6dbb34f0750c616e9f90fe1058de30e476e3e Mon Sep 17 00:00:00 2001
From: Mathis Ginkel <m.ginkel@stud.unibas.ch>
Date: Sun, 26 Apr 2026 22:19:57 +0200
Subject: [PATCH] Style: fixing some linter warnings in chat ui classes

---
 .../client/ui/chatui/ChatBoxController.java     | 17 +++++------------
 .../client/ui/chatui/ChatViewController.java    | 13 ++-----------
 2 files changed, 7 insertions(+), 23 deletions(-)

diff --git a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatBoxController.java b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatBoxController.java
index bfb51b0..46bfe4f 100644
--- a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatBoxController.java
+++ b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatBoxController.java
@@ -21,7 +21,6 @@ import javafx.scene.control.MenuButton;
 import javafx.scene.control.MenuItem;
 import javafx.scene.control.Tab;
 import javafx.scene.control.TabPane;
-import javafx.scene.layout.HBox;
 import javafx.scene.layout.Priority;
 import javafx.scene.layout.VBox;
 
@@ -31,16 +30,10 @@ public class ChatBoxController {
 
     private final ChatController chatController;
 
-    @FXML private VBox chatBox;
-
     @FXML private TabPane chatTabPane;
 
     @FXML private MenuButton addWhisperChatButton;
 
-    @FXML private HBox menuBox;
-
-    private FXMLLoader fxmlLoader;
-
     private final List<String> activeWhisperChats;
 
     @FXML private final Map<String, Tab> usernameTabMap;
@@ -77,7 +70,7 @@ public class ChatBoxController {
         ChatModel globalChatModel = new ChatModel(global, username, -1, null);
         chatController.getChatModelMap().put(new ChatController.ChatKey(global), globalChatModel);
         addChatTab("GLOBAL", globalChatModel, global);
-        addWhisperChatButton.setOnAction(event -> addWhisperChatButton.show());
+        addWhisperChatButton.setOnAction(_ -> addWhisperChatButton.show());
     }
 
     /**
@@ -97,7 +90,7 @@ public class ChatBoxController {
                     MenuItem menuItem = new MenuItem(targetUserName);
                     addWhisperChatButton.getItems().add(menuItem);
                     menuItem.setOnAction(
-                            event ->
+                            _ ->
                                     addWhisperChat(
                                             targetUserName,
                                             new ChatModel(
@@ -131,7 +124,7 @@ public class ChatBoxController {
                         if (oldUsername.equals(item.getText())) {
                             item.setText(newUsername);
                             item.setOnAction(
-                                    event ->
+                                    _ ->
                                             addWhisperChat(
                                                     newUsername,
                                                     new ChatModel(
@@ -203,7 +196,7 @@ public class ChatBoxController {
                     try {
                         ChatViewController chatViewController =
                                 new ChatViewController(
-                                        this.chatController, chatModel, this.username, this);
+                                        this.chatController, chatModel, this);
 
                         ChatKey chatKey;
                         if (chatType.equals(ChatType.WHISPER)) {
@@ -218,7 +211,7 @@ public class ChatBoxController {
                         VBox vbox = new VBox();
                         VBox.setVgrow(vbox, Priority.ALWAYS);
                         vbox.getChildren().add(load);
-                        chatModel.addListener((msg) -> chatViewController.showMessage(msg));
+                        chatModel.addListener(chatViewController::showMessage);
                         Tab newChat = new Tab(title, vbox);
                         usernameTabMap.put(title, newChat);
                         chatTabPane.getTabs().add(newChat);
diff --git a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatViewController.java b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatViewController.java
index cb8dc1b..fc9bff8 100644
--- a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatViewController.java
+++ b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/ui/chatui/ChatViewController.java
@@ -13,7 +13,6 @@ import javafx.scene.control.Label;
 import javafx.scene.control.ScrollPane;
 import javafx.scene.control.Tab;
 import javafx.scene.control.TextField;
-import javafx.scene.layout.HBox;
 import javafx.scene.layout.VBox;
 
 /** Responsible for the presentation of the ChatModel to the Client */
@@ -24,10 +23,6 @@ public class ChatViewController implements Initializable {
 
     @FXML private TextField inputField;
 
-    @FXML private VBox chatInterfaceVBox;
-
-    @FXML private HBox controlBar;
-
     @FXML private ScrollPane scrollPane;
 
     @FXML private VBox chat;
@@ -46,8 +41,6 @@ public class ChatViewController implements Initializable {
 
     private final ChatModel chatModel;
 
-    private final String username;
-
     private final ChatController controller;
 
     private static final int CHAT_PADDING = 20;
@@ -55,10 +48,8 @@ public class ChatViewController implements Initializable {
     public ChatViewController(
             ChatController chatController,
             ChatModel chatModel,
-            String username,
             ChatBoxController chatBoxController) {
         this.controller = chatController;
-        this.username = username;
         this.chatModel = chatModel;
         this.chatBoxController = chatBoxController;
         tabIsOpen = true;
@@ -74,8 +65,8 @@ public class ChatViewController implements Initializable {
      */
     @Override
     public void initialize(URL location, ResourceBundle resourceBundle) {
-        inputField.setOnAction(event -> sendMessage());
-        sendButton.setOnAction(event -> sendMessage());
+        inputField.setOnAction(_ -> sendMessage());
+        sendButton.setOnAction(_ -> sendMessage());
         scrollPane.vvalueProperty().bind(chat.heightProperty());
     }