From b082cbb5f2a763d6e5ea226361732f1bab37b73b Mon Sep 17 00:00:00 2001
From: Lars Simon Winzer <lars.winzer@stud.unibas.ch>
Date: Mon, 30 Mar 2026 15:48:26 +0200
Subject: [PATCH] Ci: Update severity for checkstyle file and group rules
 accordingly

---
 config/checkstyle/checkstyle.xml | 202 +++++++++++++++++++------------
 1 file changed, 123 insertions(+), 79 deletions(-)

diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index f51f87a..cf13a3f 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -16,20 +16,49 @@
         <property name="file" value="${suppressionFile}"/>
     </module>
 
+
+    <!-- ERROR — Correctness & Bugs -->
+    <!-- Violations that can cause runtime errors or directly affect correctness. -->
+
     <!-- Only allow spaces -->
     <!-- https://checkstyle.sourceforge.io/checks/whitespace/filetabcharacter.html -->
     <module name="FileTabCharacter"/>
 
-    <!-- Maximale Zeilenlänge (AOSP enforces 100 lines, the Google Java Style Guide 80)-->
-    <!-- https://checkstyle.sourceforge.io/checks/sizes/linelength.html -->
-    <module name="LineLength">
-        <property name="max" value="100"/>
-    </module>
-
     <module name="TreeWalker">
-        <!-- Allows for emptylines BETWEEN methods and classes but DISALLOWS newlines after an opening bracket -->
-        <!-- https://checkstyle.sourceforge.io/checks/whitespace/emptylineseparator.html -->
+        <!-- No wildcard imports (import x.*) -->
+        <!-- https://checkstyle.sourceforge.io/checks/imports/avoidstarimport.html -->
+        <module name="AvoidStarImport"/>
+
+        <!-- No unused imports -->
+        <!-- https://checkstyle.sourceforge.io/checks/imports/unusedimports.html -->
+        <module name="UnusedImports"/>
+
+        <!-- Require string literals to be compared with .equals and not == -->
+        <!-- https://checkstyle.sourceforge.io/checks/coding/stringliteralequality.html -->
+        <module name="StringLiteralEquality"/>
+
+        <!-- Disallow empty code blocks after catch -->
+        <!-- https://checkstyle.sourceforge.io/checks/blocks/emptycatchblock.html -->
+        <module name="EmptyCatchBlock">
+            <property name="exceptionVariableName" value="expected|ignored"/>
+        </module>
+
+        <!-- Disallow System.out.println -->
+        <!-- https://checkstyle.sourceforge.io/checks/regexp/regexp.html -->
+        <module name="Regexp">
+            <property name="id" value="SystemOutErr"/>
+            <property name="format" value="System\.(out|err)\.print"/>
+            <property name="illegalPattern" value="true"/>
+            <property name="message" value="No `System.out.print(err)` allowed — use a logger."/>
+        </module>
+
+
+        <!-- WARNING — Style & Conventions -->
+        <!-- Violations against agreed conventions that reduce readability and maintainability. -->
         <module name="EmptyLineSeparator">
+            <property name="severity" value="warning"/>
+            <!-- Allows for emptylines BETWEEN methods and classes but DISALLOWS newlines after an opening bracket -->
+            <!-- https://checkstyle.sourceforge.io/checks/whitespace/emptylineseparator.html -->
             <property name="allowNoEmptyLineBetweenFields" value="true"/>
             <property name="tokens" value="
                 METHOD_DEF,
@@ -42,17 +71,10 @@
             "/>
         </module>
 
-        <!-- No wildcard imports (import x.*) -->
-        <!-- https://checkstyle.sourceforge.io/checks/imports/avoidstarimport.html -->
-        <module name="AvoidStarImport"/>
-
-        <!-- No unused imports -->
-        <!-- https://checkstyle.sourceforge.io/checks/imports/unusedimports.html -->
-        <module name="UnusedImports"/>
-
         <!-- No unordered / ungrouped imports -->
         <!-- https://checkstyle.sourceforge.io/checks/imports/importorder.html -->
         <module name="ImportOrder">
+            <property name="severity" value="warning"/>
             <property name="option" value="top"/>
             <property name="groups" value="/^import static\..+/,*"/>
             <property name="separated" value="true"/>
@@ -62,33 +84,94 @@
 
         <!-- Classes, enums, records, ... as PascalCase -->
         <!-- https://checkstyle.sourceforge.io/checks/naming/typename.html -->
-        <module name="TypeName"/>
+        <module name="TypeName">
+            <property name="severity" value="warning"/>
+        </module>
 
         <!-- Method names as camelCase -->
         <!-- https://checkstyle.sourceforge.io/checks/naming/methodname.html -->
-        <module name="MethodName"/>
+        <module name="MethodName">
+            <property name="severity" value="warning"/>
+        </module>
 
         <!-- Parameter names as camelCase -->
         <!-- https://checkstyle.sourceforge.io/checks/naming/parametername.html -->
-        <module name="ParameterName"/>
+        <module name="ParameterName">
+            <property name="severity" value="warning"/>
+        </module>
 
         <!-- Lokal variables as camelCase -->
         <!-- https://checkstyle.sourceforge.io/checks/naming/localvariablename.html -->
-        <module name="LocalVariableName"/>
+        <module name="LocalVariableName">
+            <property name="severity" value="warning"/>
+        </module>
 
         <!-- Constants as UPPER_SNAKE_CASE -->
         <!-- https://checkstyle.sourceforge.io/checks/naming/constantname.html -->
-        <module name="ConstantName"/>
+        <module name="ConstantName">
+            <property name="severity" value="warning"/>
+        </module>
 
         <!-- Field names as camelCase -->
         <!-- https://checkstyle.sourceforge.io/checks/naming/membername.html -->
         <module name="MemberName">
+            <property name="severity" value="warning"/>
             <property name="format" value="^[a-z][a-zA-Z0-9]*$"/>
         </module>
 
+        <!-- Modifier-Reihenfolge: public static final ... -->
+        <!-- https://checkstyle.sourceforge.io/checks/modifier/modifierorder.html -->
+        <module name="ModifierOrder">
+            <property name="severity" value="warning"/>
+        </module>
+
+        <!-- Require braces arround code block (no single instruction after if/else/while/...)-->
+        <!-- https://checkstyle.sourceforge.io/checks/blocks/needbraces.html -->
+        <module name="NeedBraces">
+            <property name="severity" value="warning"/>
+        </module>
+
+        <!-- Require the left curly braces at the same line -->
+        <!-- https://checkstyle.sourceforge.io/checks/blocks/leftcurly.html -->
+        <module name="LeftCurly">
+            <property name="severity" value="warning"/>
+        </module>
+
+        <!-- Require right curly braces at the same line as following instructions -->
+        <!-- https://checkstyle.sourceforge.io/checks/blocks/rightcurly.html -->
+        <module name="RightCurly">
+            <property name="severity" value="warning"/>
+        </module>
+
+        <!-- Disallow whitespace before semicolon or bracket -->
+        <!-- https://checkstyle.sourceforge.io/checks/whitespace/nowhitespacebefore.html -->
+        <module name="NoWhitespaceBefore">
+            <property name="severity" value="warning"/>
+        </module>
+
+        <!-- Disallow whitespace after code -->
+        <!-- https://checkstyle.sourceforge.io/checks/whitespace/whitespaceafter.html -->
+        <module name="WhitespaceAfter">
+            <property name="severity" value="warning"/>
+        </module>
+
+        <!-- No trailing whitespace at line ending -->
+        <!-- https://checkstyle.sourceforge.io/checks/regexp/regexp.html -->
+        <module name="Regexp">
+            <property name="severity" value="warning"/>
+            <property name="format" value=" +$"/>
+            <property name="illegalPattern" value="true"/>
+            <property name="message" value="No trailing whitespace."/>
+        </module>
+
+
+        <!-- INFO — Complexity Limits -->
+        <!-- Metrics that serve as guidance but may legitimately be exceeded depending on context. -->
+
         <!-- Restrict length of method name -->
         <!-- https://checkstyle.sourceforge.io/checks/sizes/methodlength.html -->
         <module name="MethodLength">
+            <property name="severity" value="info"/>
             <property name="max" value="60"/>
             <property name="countEmpty" value="false"/>
         </module>
@@ -96,75 +179,36 @@
         <!-- Restrict number of parameters -->
         <!-- https://checkstyle.sourceforge.io/checks/sizes/parameternumber.html -->
         <module name="ParameterNumber">
+            <property name="severity" value="info"/>
             <property name="max" value="5"/>
         </module>
 
-        <!-- Modifier-Reihenfolge: public static final ... -->
-        <!-- https://checkstyle.sourceforge.io/checks/modifier/modifierorder.html -->
-        <module name="ModifierOrder"/>
-
-        <!-- Require braces arround code block (no single instruction after if/else/while/...)-->
-        <!-- https://checkstyle.sourceforge.io/checks/blocks/needbraces.html -->
-        <module name="NeedBraces"/>
-
-        <!-- Require the left curly braces at the same line -->
-        <!-- https://checkstyle.sourceforge.io/checks/blocks/leftcurly.html -->
-        <module name="LeftCurly"/>
-
-        <!-- Require right curly braces at the same line as following instructions -->
-        <!-- https://checkstyle.sourceforge.io/checks/blocks/rightcurly.html -->
-        <module name="RightCurly"/>
-
-        <!-- Disallow empty code blocks -->
-        <!-- https://checkstyle.sourceforge.io/checks/blocks/emptyblock.html -->
-        <module name="EmptyBlock">
-            <property name="option" value="text"/>
-        </module>
-
-        <!-- Disallow empty code blocks after catch -->
-        <!-- https://checkstyle.sourceforge.io/checks/blocks/emptycatchblock.html -->
-        <module name="EmptyCatchBlock">
-            <property name="exceptionVariableName" value="expected|ignored"/>
-        </module>
-
-        <!-- Require string literals to be compared with .equals and not == -->
-        <!-- https://checkstyle.sourceforge.io/checks/coding/stringliteralequality.html -->
-        <module name="StringLiteralEquality"/>
-
         <!-- Disallow standalone numbers in code -->
         <!-- https://checkstyle.sourceforge.io/checks/coding/magicnumber.html -->
         <module name="MagicNumber">
+            <property name="severity" value="info"/>
             <property name="ignoreNumbers" value="-1, 0, 1, 2"/>
             <property name="ignoreAnnotation" value="true"/>
         </module>
 
+        <!-- Disallow empty code blocks -->
+        <!-- https://checkstyle.sourceforge.io/checks/blocks/emptyblock.html -->
+        <module name="EmptyBlock">
+            <property name="severity" value="info"/>
+            <property name="option" value="text"/>
+        </module>
+
         <!-- Disallow nested code blocks dangling in code -->
         <!-- https://checkstyle.sourceforge.io/checks/blocks/avoidnestedblocks.html -->
-        <module name="AvoidNestedBlocks"/>
-
-        <!-- Disallow System.out.println -->
-        <!-- https://checkstyle.sourceforge.io/checks/regexp/regexp.html -->
-        <module name="Regexp">
-            <property name="id" value="SystemOutErr"/>
-            <property name="format" value="System\.(out|err)\.print"/>
-            <property name="illegalPattern" value="true"/>
-            <property name="message" value="No `System.out.print(err)` allowed — use a logger."/>
-        </module>
-
-        <!-- Disallow whitespace before semicolon or bracket -->
-        <!-- https://checkstyle.sourceforge.io/checks/whitespace/nowhitespacebefore.html -->
-        <module name="NoWhitespaceBefore"/>
-
-        <!-- Disallow whitespace after code -->
-        <!-- https://checkstyle.sourceforge.io/checks/whitespace/whitespaceafter.html -->
-        <module name="WhitespaceAfter"/>
-
-        <!-- No trailing whitespace at line ending -->
-        <!-- https://checkstyle.sourceforge.io/checks/regexp/regexp.html -->
-        <module name="Regexp">
-            <property name="format" value=" +$"/>
-            <property name="illegalPattern" value="true"/>
-            <property name="message" value="No trailing whitespace."/>
+        <module name="AvoidNestedBlocks">
+            <property name="severity" value="info"/>
         </module>
     </module>
-</module>
+
+    <!-- Maximale Zeilenlänge (AOSP enforces 100 lines, the Google Java Style Guide 80)-->
+    <!-- https://checkstyle.sourceforge.io/checks/sizes/linelength.html -->
+    <module name="LineLength">
+        <property name="severity" value="info"/>
+        <property name="max" value="100"/>
+    </module>
+</module>
\ No newline at end of file