From f841eecb93de7fe690e333a7a32f96b0ca6f938d Mon Sep 17 00:00:00 2001 From: Lars Simon Winzer Date: Mon, 30 Mar 2026 14:13:29 +0200 Subject: [PATCH 1/3] Fix: disallow failure for checkstyle job for merge requests --- .gitlab-ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 04bb8bd..3c78f55 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -22,7 +22,7 @@ stages: .on-mr: &on-mr rules: - if: '$CI_PIPELINE_SOURCE == "merge_request_event"' - allow_failure: true # deactivate after all issues (shown by checkstyle) have been resolved + allow_failure: false # Jobs checkstyle: @@ -48,7 +48,7 @@ checkstyle-mr: image: gradle:9.3.1-jdk25 script: - gradle checkstyleMain checkstyleTest - allow_failure: true + allow_failure: false artifacts: when: always paths: @@ -66,6 +66,7 @@ checkstyle-report: - job: checkstyle-mr artifacts: true optional: true + when: always rules: - if: '$CI_PIPELINE_SOURCE == "merge_request_event"' script: From f9b866fc403f3f8d67a0da585778fe2eee3945e7 Mon Sep 17 00:00:00 2001 From: Lars Simon Winzer Date: Mon, 30 Mar 2026 14:15:11 +0200 Subject: [PATCH 2/3] Add: Violator dummy class to test pipeline behaviour --- .../ch/unibas/dmi/dbis/cs108/casono/server/Violator.java | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java diff --git a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java new file mode 100644 index 0000000..854b34c --- /dev/null +++ b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java @@ -0,0 +1,7 @@ +package ch.unibas.dmi.dbis.cs108.casono.server; + +public class Violator { + public void dummy() { + System.out.println("This is a disallowed sysout statement, triggering the failure of the merge request"); + } +} From 9d4afdc3e8a7a6e63016dff0d3be1d6dc26f18c6 Mon Sep 17 00:00:00 2001 From: Lars Simon Winzer Date: Mon, 30 Mar 2026 14:20:01 +0200 Subject: [PATCH 3/3] Remove: Violator dummy file --- .../ch/unibas/dmi/dbis/cs108/casono/server/Violator.java | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java diff --git a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java b/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java deleted file mode 100644 index 854b34c..0000000 --- a/src/main/java/ch/unibas/dmi/dbis/cs108/casono/server/Violator.java +++ /dev/null @@ -1,7 +0,0 @@ -package ch.unibas.dmi.dbis.cs108.casono.server; - -public class Violator { - public void dummy() { - System.out.println("This is a disallowed sysout statement, triggering the failure of the merge request"); - } -}