Fix: robust response parsing and clearer errors in ClientService Detect +OK / -ERR / -ERROR, strip leading tabs, collect response lines reliably and improve exception unwrapping.

src/main/java/ch/unibas/dmi/dbis/cs108/casono/client/network/ClientService.java

@@ -138,33 +138,64 @@ public class ClientService {
                 () -> {
                     try {
                         writeToTransport(message);
-                        String responseText = null;
+                        String responseText = clienttcptransport.read().payload();
+                        logger.info("Raw message '{}'", responseText);
 
-                        responseText = clienttcptransport.read().payload();
+                        boolean hasStatus = false;
-                        logger.info("Raw message '" + responseText + "'");
+                        boolean success = false;
-                        Boolean success = null;
+                        for (String rawLine : responseText.split("\n")) {
-                        int count = 0;
+                            String line = rawLine;
-                        for (String line : responseText.split("\n")) {
+                            if (!hasStatus) {
-                            if (success == null) {
                                 if ("+OK".equals(line)) {
                                     success = true;
+                                    hasStatus = true;
                                     continue;
-
-                                } else if (("-ERROR").equals(responseText)) {
-                                    success = false;
                                 }
+                                if (line.startsWith("-ERR") || line.startsWith("-ERROR")) {
+                                    success = false;
+                                    hasStatus = true;
                                     continue;
-                            } else if ("END".equals(line)) {
+                                }
+                                // ignore any lines before the status indicator
+                                continue;
+                            }
+
+                            if ("END".equals(line)) {
                                 break;
                             }
-                            line = line.replaceFirst("^\t", "");
+
+                            // strip a single leading tab if present (protocol formatting)
+                            if (line.startsWith("\t")) {
+                                line = line.substring(1);
+                            }
                             response.add(line);
                         }
-                        if (success != null && success) {
+
-                            return;
+                        if (!hasStatus) {
+                            // Fallback for servers that do not place the status on a
+                            // dedicated line: try to detect status markers anywhere
+                            // in the payload to remain compatible with older servers.
+                            if (responseText.contains("+OK")) {
+                                success = true;
+                                hasStatus = true;
+                            } else if (responseText.contains("-ERR")
+                                    || responseText.contains("-ERROR")) {
+                                success = false;
+                                hasStatus = true;
                             } else {
-                            throw new RuntimeException("Error in " + message + ": " + response);
+                                throw new RuntimeException(
+                                        "No status line in response for '"
+                                                + message
+                                                + "': "
+                                                + responseText);
                             }
+                        }
+
+                        if (success) {
+                            return;
+                        }
+
+                        throw new RuntimeException("Error in " + message + ": " + response);
                     } catch (Exception e) {
                         throw getRuntimeException(e);
                     }
@@ -200,15 +231,14 @@ public class ClientService {
      * @return A RuntimeException representing the cause of the original exception.
      */
     private static RuntimeException getRuntimeException(Exception e) {
-        Throwable reason = e.getCause();
+        Throwable cause = e.getCause();
-        RuntimeException re;
+        if (cause == null) {
-        if (reason == null) {
+            return e instanceof RuntimeException ? (RuntimeException) e : new RuntimeException(e);
-            reason = e;
-        } else if (reason instanceof RuntimeException rte) {
-            re = rte;
         }
-        re = new RuntimeException(reason);
+        if (cause instanceof RuntimeException) {
-        return re;
+            return (RuntimeException) cause;
+        }
+        return new RuntimeException(cause);
     }
 
     /**